Skip to content

Pre-create outut folder for Lighthouse reports #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bollwyvl
Copy link
Collaborator

continues towards #206.

Sorry to let this slide. Turns out I missed a few steps in the copy-and-paste of the templates, and the outputFolder needs to already exist. This would apparently fix, for example, this run:
https://github.com/pandas-dev/pydata-sphinx-theme/runs/805676569?check_suite_focus=true

However, the timeout error still eludes me... but maybe we can start seeing some reports, some of the time!

@jorisvandenbossche jorisvandenbossche merged commit b5a2fd0 into pydata:master Jun 25, 2020
@jorisvandenbossche
Copy link
Member

So it seems there now is a report (sometimes it times out, but often it succeeds): https://github.com/pandas-dev/pydata-sphinx-theme/actions/runs/147113570

But when checking the report, it seems it got an error loading the page ..

Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404)

@bollwyvl
Copy link
Collaborator Author

So maybe instead of curl, I should try wget --mirror --retry-on-http-error=404 which will crawl the whole page, and presumably fail if any of the assets aren't available.

Or, and this would likely put it back in a testable-per-PR state, perhaps testing it against a locally running server would be sufficient... there would be a number of false alarms (e.g. no https, http/2, and probably some cross-domain gotchas for localhost) but for the accessibility stuff, it might be completely sufficient... i'll investigate that path...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants