Skip to content

Enforce mypy compliance in CI #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 10, 2019
Merged

Enforce mypy compliance in CI #3197

merged 7 commits into from
Aug 10, 2019

Conversation

crusaderky
Copy link
Contributor

No description provided.

@crusaderky
Copy link
Contributor Author

mypy failures now make CI fail: https://dev.azure.com/xarray/xarray/_build/results?buildId=511&view=logs

Now moving to solve them...

crusaderky
crusaderky commented Aug 9, 2019
View reviewed changes
xarray/core/dataset.py
coords: Mapping[Hashable, Any] = None,
attrs: Mapping = None,
attrs: Mapping[Hashable, Any] = None,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support Dataset({"x": [1, 2]}), where one of the data_vars is silently moved to coords

@crusaderky crusaderky changed the title WIP: Enforce mypy compliance in CI Enforce mypy compliance in CI Aug 9, 2019
@crusaderky
Copy link
Contributor Author

Ready for review and merge

max-sixty
max-sixty approved these changes Aug 9, 2019
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me, though worth waiting if anyone has objections. If this becomes a burden for new contributors, we can easily revert

@max-sixty
Copy link
Collaborator

Is there a pre-commit for mypy?

@crusaderky
Copy link
Contributor Author

@max-sixty added and tested :)

@shoyer
Copy link
Member

shoyer commented Aug 10, 2019

Okay, we can give this a try

@crusaderky
Copy link
Contributor Author

In it goes

@crusaderky crusaderky merged commit befc72f into pydata:master Aug 10, 2019
@crusaderky crusaderky deleted the mypy_ci branch August 11, 2019 08:49
dcherian added a commit to dcherian/xarray that referenced this pull request Aug 14, 2019
@dcherian
Merge remote-tracking branch 'upstream/master' into compat-override
cbd5afb 
* upstream/master:
  chunk sparse arrays (pydata#3202)
  Annotations for .data_vars() and .coords() (pydata#3207)
  Remove duck_array_ops.as_like_arrays() (pydata#3204)
  Match mypy version between CI and pre-commit hook (pydata#3203)
  BUG fix +test .sel method gives error with float32 values (pydata#3153)
  fix precommit file (pydata#3201)
  Enforce mypy compliance in CI (pydata#3197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crusaderky @max-sixty @shoyer