Remove duck_array_ops.as_like_arrays() #3204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has some questionable coercion logic that no longer seems to be necessary.
max-sixty
approved these changes
Aug 11, 2019
Merged
|
I did have to disable a few of the sparse tests that entailed element-wise comparison between dense and sparse arrays. This currently isn't supported by sparse (but perhaps it should be): pydata/sparse#270 |
crusaderky
approved these changes
Aug 12, 2019
shoyer
commented
Aug 12, 2019
| param( | ||
| do("broadcast_equals", make_xrvar({"x": 10, "y": 5})), | ||
| False, | ||
| marks=xfail(reason="https://github.com/pydata/sparse/issues/270"), |
There was a problem hiding this comment.
This issue is fixed, so we should be able to re-enable these tests after the next sparse release.
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Aug 14, 2019
* upstream/master: chunk sparse arrays (pydata#3202) Annotations for .data_vars() and .coords() (pydata#3207) Remove duck_array_ops.as_like_arrays() (pydata#3204) Match mypy version between CI and pre-commit hook (pydata#3203) BUG fix +test .sel method gives error with float32 values (pydata#3153) fix precommit file (pydata#3201) Enforce mypy compliance in CI (pydata#3197)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has some questionable coercion logic that no longer seems to be necessary.
Not a user facing change.
black . && mypy . && flake8