Skip to content

Remove all references to _infer #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Blocked by #2167.

This would be the next step towards the new way of doing inference. We no longer have any internal references to _infer() or assignments to it.
Since this is private API we don't need a news entry.

Next step would be to start transitioning some of the calls to infer() to be infer_object.

Type of Changes

Type
🔨 Refactoring

Related Issue

@DanielNoord DanielNoord added the Enhancement ✨ Improvement to a component label May 7, 2023
@DanielNoord DanielNoord added this to the 3.0.0a3 milestone May 7, 2023
@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #2168 (c8c01ef) into main (0740a0d) will increase coverage by 0.01%.
The diff coverage is 98.95%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2168      +/-   ##
==========================================
+ Coverage   92.53%   92.55%   +0.01%     
==========================================
  Files          94       94              
  Lines       10804    10825      +21     
==========================================
+ Hits         9998    10019      +21     
  Misses        806      806              
Flag Coverage Δ
linux 92.31% <98.95%> (+0.01%) ⬆️
pypy 87.51% <98.95%> (+0.02%) ⬆️
windows 92.14% <98.95%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
astroid/nodes/node_classes.py 94.86% <ø> (-0.02%) ⬇️
astroid/inference.py 94.96% <98.90%> (+0.38%) ⬆️
astroid/nodes/node_ng.py 91.86% <100.00%> (-0.82%) ⬇️
astroid/objects.py 94.26% <100.00%> (+0.40%) ⬆️

@jacobtylerwalls
Copy link
Member

Superseded by #2171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Improvement to a component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants