-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Extended consider-using-tuple
check to cover in
comparisons
#4768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba3618e
to
9fcb74b
Compare
3df9adb
to
e2817f7
Compare
Pierre-Sassoulas
approved these changes
Jul 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
e2817f7
to
0e6e666
Compare
21 tasks
0e6e666
to
244055c
Compare
Pierre-Sassoulas
approved these changes
Jul 29, 2021
cdce8p
added a commit
to cdce8p/pylint
that referenced
this pull request
Aug 12, 2021
…pylint-dev#4768)" This reverts commit ca3bc53.
cdce8p
added a commit
that referenced
this pull request
Aug 12, 2021
Revert "Extended consider-using-tuple check to cover 'in' comparisons (#4768)"
This was referenced Aug 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Extend
consider-using-tuple
check from theCodeStyleChecker
extension to recognize lists / sets inin
comparisons.Some examples
Previously the check was only used inside
For
looks andComprehensions
.