Fix parsing of unknown message IDs #6315
Conversation
pylint/config/callback_actions.py
Outdated
| # pylint: disable-next=fixme | ||
| # TODO: Optparse: Raise an informational warning here | ||
| pass |
There was a problem hiding this comment.
What about doing it right now ? I don't like this silent fail, in fact we had a more damaging silent fail before and we've been lucky that Marc signaled the issue.
There was a problem hiding this comment.
Sure! Drafting this then!
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "functional_append": { | |||
| "enable": ["locally-disabled"] | |||
| "enable": ["locally-disabled"], | |||
| "disable": ["logging-format-interpolation"] | |||
pylint/config/callback_actions.py
Outdated
| pass | ||
| except exceptions.UnknownMessageError: | ||
| # pylint: disable-next=fixme | ||
| # TODO: Optparse: Raise an informational warning here |
There was a problem hiding this comment.
@cdce8p This was caused because in the homeassistant config there is a message that has been removed. This caused us to stop parsing the disable key when we reached it.
Didn't know that. I don't usually check all disable message ids to see if they are still valid.
A warning for it (not just informational) would be nice.
Pull Request Test Coverage Report for Build 2169121063
💛 - Coveralls |
| @@ -0,0 +1,3 @@ | |||
| ************* Module {abspath} | |||
There was a problem hiding this comment.
This kind of silent fail are a pain to deal with, glad it's fixed !
Co-authored-by: Pierre Sassoulas <[email protected]>
Pierre-Sassoulas
force-pushed
the
homeassistant
branch
from
5ab8b41 to
ac89c5f
Compare
|
Thanks for the clean up @Pierre-Sassoulas |
and preferred name in
script/.contributors_aliases.jsonType of Changes
Description
The
try...expectshould have been placed differently. The test was wrong here as well,"logging-format-interpolation"should be indisableeven after the previous message is unknown.@cdce8p This was caused because in the
homeassistantconfig there is a message that has been removed. This caused us to stop parsing thedisablekey when we reached it.Ref #6293.
Closes #4324.