Skip to content

Upgrade configuration example and add toml example #6529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
βœ“ πŸ“œ Docs

Description

Necessary for #6527

@Pierre-Sassoulas Pierre-Sassoulas added Documentation πŸ“— Maintenance Discussion or action around maintaining pylint or the dev workflow labels May 6, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.14.0 milestone May 6, 2022
@Pierre-Sassoulas Pierre-Sassoulas added Blocker πŸ™… Blocks the next release Beta-Blocker πŸ™…πŸ©Έ If this issue is not fixed before the beta release, our blood pressure increase too much labels May 6, 2022
@coveralls
Copy link

coveralls commented May 6, 2022

Pull Request Test Coverage Report for Build 2299563254

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.326%

Totals Coverage Status
Change from base Build 2299467367: 0.0%
Covered Lines: 16029
Relevant Lines: 16815

πŸ’› - Coveralls

@DanielNoord
Copy link
Collaborator

DanielNoord commented May 9, 2022

Just to recap:

  • Add test to check if --generate... produces a valid configuration file
  • Fix --generate-rcfile adding None where it shouldn't
  • Look into "optional arguments" for --generate-toml-config

Am I missing something?

@Pierre-Sassoulas
Copy link
Member Author

I don't think of anything else. Should we do the three at once or first fix then test ?

@DanielNoord
Copy link
Collaborator

I don't think of anything else. Should we do the three at once or first fix then test ?

Point 3 is fairly easy and could be separated. It's likely just an if name == "optional arguments": continue that needs to be added somewhere.
Point 1 and 2 should be done at the same time. Haven't looked into it yet and I actually don't have much time this week. But I also want to get 2.14 out so I'm not managing my priorities very well πŸ˜…

@Pierre-Sassoulas
Copy link
Member Author

I also want to get 2.14 out so I'm not managing my priorities very well

Well, take it easy :)

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the upgrade-configuration-example branch from 787a3c8 to 62cf71f Compare May 10, 2022 08:59
@Pierre-Sassoulas Pierre-Sassoulas merged commit 133e2e5 into pylint-dev:main May 10, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the upgrade-configuration-example branch May 10, 2022 09:18
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beta-Blocker πŸ™…πŸ©Έ If this issue is not fixed before the beta release, our blood pressure increase too much Blocker πŸ™… Blocks the next release Documentation πŸ“— Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants