Skip to content

Make sure that --generate-rcfile generates a valid file #6566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 10, 2022
Merged

Make sure that --generate-rcfile generates a valid file #6566

merged 5 commits into from
May 10, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

Ref. #6529

Fixes the issues with ini.

@DanielNoord DanielNoord added this to the 2.14.0 milestone May 9, 2022
DanielNoord
DanielNoord commented May 9, 2022
View reviewed changes
@coveralls
Copy link

coveralls commented May 9, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2298704967

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 95.324%
Totals Coverage Status
Change from base Build 2296906326: 0.007%
Covered Lines: 16023
Relevant Lines: 16809
💛 - Coveralls

DanielNoord
DanielNoord commented May 9, 2022
View reviewed changes
@DanielNoord
Copy link
Collaborator Author

@Pierre-Sassoulas This passes tests and should fix the last issues in the original PR.

Pierre-Sassoulas
Pierre-Sassoulas approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Let's wrap up 2.14-beta :)

@Pierre-Sassoulas Pierre-Sassoulas merged commit 0199504 into pylint-dev:main May 10, 2022
@DanielNoord DanielNoord deleted the optional-2 branch May 10, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Bug 🪲
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas