-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[refactor] Use a generator for '_has_variadic_argument' #6770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Pierre-Sassoulas
merged 2 commits into
pylint-dev:main
from
Pierre-Sassoulas:faster-variadic-check-in-basic-checker
May 31, 2022
Merged
[refactor] Use a generator for '_has_variadic_argument' #6770
Pierre-Sassoulas
merged 2 commits into
pylint-dev:main
from
Pierre-Sassoulas:faster-variadic-check-in-basic-checker
May 31, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2414623048
π - Coveralls |
This comment has been minimized.
This comment has been minimized.
DanielNoord
approved these changes
May 31, 2022
π€ Effect of this PR on checked open source code: π€ Effect on pandas:
The following messages are now emitted:
The following messages are no longer emitted:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Follow-up to #6769, probably a small performance increase (?), but I find this easier to understand.