Skip to content

Run Primer / Main on all pushes to main #6772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

See #6769 (comment)

@DanielNoord
Copy link
Collaborator Author

Note that we are correctly skipping Primer / Run on this PR as we are only changing something in Primer / Main. So, it doesn't make sense to run the workflow as we will never be able to gauge its impact.

Nice to see that is working as intended :)

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an unrelated thought. Obviousely we don't want a changelog entry for this and it has the bug label (rightly so). So regarding the changelog check maybe it could be "only the primer/documentation/maintenance label" or a "no-changelog" label with any combination of other label.

@DanielNoord
Copy link
Collaborator Author

Just an unrelated thought. Obviousely we don't want a changelog entry for this and it has the bug label (rightly so). So regarding the changelog check maybe it could be "only the primer/documentation/maintenance label" or a "no-changelog" label with any combination of other label.

Let's create a no-news label like other projects do!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2414901848

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.515%

Totals Coverage Status
Change from base Build 2414895377: 0.0%
Covered Lines: 16229
Relevant Lines: 16991

πŸ’› - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants