Changing flake8 to have max-line-length of 115 #8362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Maintenance
ollie-iterators
requested review from
cdce8p and
Pierre-Sassoulas
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8362 +/- ##
=======================================
Coverage 95.56% 95.56%
=======================================
Files 178 178
Lines 18763 18766 +3
=======================================
+ Hits 17930 17933 +3
Misses 833 833
|
This comment has been minimized.
This comment has been minimized.
|
Is there anything that needs to be done for this PR to be merged? |
Pierre-Sassoulas
previously approved these changes
Mar 2, 2023
|
The pre-commit fail seems genuine and not caused by my suggestion. |
This comment has been minimized.
This comment has been minimized.
|
Strange, when I check out the file that has an error, 'pylint/config/config_initialization.py', it says that it only has 124 lines, and the pre-commit error is about lines 127 and 128. |
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 65654f4 |
|
This seem like a pre-commit.ci bug, maybe due to bad caching. It works locally too. |
Pierre-Sassoulas
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Changing flake8 to have a max-line-length of 115 because there are issues with changing it to 103. This makes the code easier to understand.
Refs #XXXX
Closes #XXXX