[pre-commit] Transition from flake8/autoflake to ruff #8372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Maintenance
ruff is faster and support pyproject.toml. flake8-typing-import is not implemented but it checks for things in python version < 3.7.2 that we do not support.
Pierre-Sassoulas
force-pushed
the
fix-main-move-to-ruff
branch
from
e8c579a to
184a244
Compare
Closed
|
It's strange that there is no security check that forces the user to be up to date with the master/main branch before committing a pull request to the master/main branch. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8372 +/- ##
=======================================
Coverage 95.56% 95.56%
=======================================
Files 178 178
Lines 18766 18766
=======================================
Hits 17933 17933
Misses 833 833
|
|
The continuous integration takes a long time and it's very rare that a problem happen. When it happens we fix main and it does not impact contributors too much. So it's a balance we try to achieve between performance and not breaking main. |
DanielNoord
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
ruff is faster and support pyproject.toml and python 3.7. flake8-typing-import is not implemented but it checks for things in python version < 3.7.2 that we do not support. Fix main following #8362 that broke it.