Add regression test for #8554 #8682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
Needs astroid update
|
This one is going to be technical, here we need astroid 3.0.0a3 but the backport will need 2.15.5. |
Pierre-Sassoulas
added
Needs backport
|
Upgrading astroid in #8685 because updating the version is not the only thing to do. |
|
(So we can backport) |
jacobtylerwalls
commented
May 14, 2023
jacobtylerwalls
removed
the
Needs astroid update
Pierre-Sassoulas
approved these changes
Jun 7, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8682 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 173 173
Lines 18386 18386
=======================================
Hits 17618 17618
Misses 768 768 |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 7, 2023
Co-authored-by: Pierre Sassoulas <[email protected]> (cherry picked from commit 2acca90)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jun 7, 2023
Co-authored-by: Pierre Sassoulas <[email protected]> (cherry picked from commit 2acca90) Co-authored-by: Jacob Walls <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #8554
Depends on pylint-dev/astroid#2177