-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Upgrade astroid to 3.0.0a4 #8685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade astroid to 3.0.0a4 #8685
Conversation
Thanks, I'll push some commits to this branch. 👍 |
9919387
to
11bb684
Compare
Re: the remaining failure: I remember looking at this a couple weeks ago. The test passes in isolation, so there's a pollution issue. I haven't made it much farther. |
Looked into it a little into it might be due to |
We should bump all the way to astroid 3.0.0a4, because the primer will be busted without pylint-dev/astroid#2181. |
See pylint-dev/astroid#2185 for a fix. |
Just waiting on astroid 3.0.0a4 |
We now need to use repr_name.
11bb684
to
acf097b
Compare
I'm looking into the PyPy 3.8 failure, but it doesn't look serious. Thinking about writing a follow-up issue (and xfailing it with a link) |
This comment has been minimized.
This comment has been minimized.
So we have a test The failure of it on PyPy 3.8 is transient; rerunning it passed eventually. This is not stable enough for CI, so we should add the same skip we added in astroid, see pylint-dev/astroid#2181 (comment) and 1f9ba55. Where exactly the failure is happening is interesting. We're correctly catching the RecursionError and reraising as InferenceError, but chaining it to RecursionError as the cause is becoming problematic, maybe because InferenceError is bloated with all kinds of references to nodes. I'm going to experiment by only chaining the exceptions on versions 3.9+ (and push the commit to this branch). |
Oof, I'd have to do this in astroid. Will come back with a better proposal. |
The test file lints on Python 3.8 without trouble, but pytest aborts with exit code 134.
I skipped the test on Python 3.8. I mentioned in the commit message for the skip that the file lints fine on python 3.8, rather it's pytest that's choking. Not necessary to look into at this juncture IMO. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8685 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 173 173
Lines 18386 18386
=======================================
Hits 17618 17618
Misses 768 768
|
Type of Changes
Description
Refs #8682, #8738