[Backport maintenance/2.17.x] Fix crash in invalid-metaclass check
#8700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
(cherry picked from commit 7a562dd)
Pierre-Sassoulas
approved these changes
May 18, 2023
This was added only to cover the second exception type that needs to be handled here; but backporting it to branches supporting 3.7 would require rewriting the test case.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## maintenance/2.17.x #8700 +/- ##
===================================================
Coverage 95.56% 95.56%
===================================================
Files 178 178
Lines 18809 18812 +3
===================================================
+ Hits 17975 17978 +3
Misses 834 834
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 7a562dd from #8699.