Skip to content

[Backport maintenance/2.17.x] Fix crash in invalid-metaclass check #8700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2023
Merged

[Backport maintenance/2.17.x] Fix crash in invalid-metaclass check #8700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1251811
Fix crash in `invalid-metaclass` check (#8699)
jacobtylerwalls May 18, 2023
8081bb5
Remove test case for inconsistent-mro
jacobtylerwalls May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/whatsnew/fragments/8698.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix crash in ``invalid-metaclass`` check when a metaclass had duplicate bases.

Closes #8698
5 changes: 4 additions & 1 deletion pylint/checkers/typecheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,10 @@ def _no_context_variadic(


def _is_invalid_metaclass(metaclass: nodes.ClassDef) -> bool:
mro = metaclass.mro()
try:
mro = metaclass.mro()
except (astroid.DuplicateBasesError, astroid.InconsistentMroError):
return True
return not any(is_builtin_object(cls) and cls.name == "type" for cls in mro)


Expand Down
8 changes: 8 additions & 0 deletions tests/functional/i/invalid/invalid_metaclass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,11 @@ class Invalid(metaclass=invalid_metaclass_1): # [invalid-metaclass]

class InvalidSecond(metaclass=invalid_metaclass_2): # [invalid-metaclass]
pass


class MetaclassWithInvalidMRO(type(object), type(object)): # [duplicate-bases]
pass


class FifthInvalid(metaclass=MetaclassWithInvalidMRO): # [invalid-metaclass]
pass
2 changes: 2 additions & 0 deletions tests/functional/i/invalid/invalid_metaclass.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ invalid-metaclass:49:0:49:18:ThirdInvalid:Invalid metaclass '2' used:UNDEFINED
invalid-metaclass:53:0:53:19:FourthInvalid:Invalid metaclass 'Instance of invalid_metaclass.InvalidAsMetaclass' used:UNDEFINED
invalid-metaclass:65:0:65:13:Invalid:Invalid metaclass 'int' used:UNDEFINED
invalid-metaclass:69:0:69:19:InvalidSecond:Invalid metaclass '1' used:UNDEFINED
duplicate-bases:73:0:73:29:MetaclassWithInvalidMRO:Duplicate bases for class 'MetaclassWithInvalidMRO':UNDEFINED
invalid-metaclass:77:0:77:18:FifthInvalid:Invalid metaclass 'MetaclassWithInvalidMRO' used:UNDEFINED