Cleanup InstallRequirement.egg_info_path #7081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
pradyunsg
force-pushed
the
cleanup-egg_info_path
branch
from
1f74e7e to
fcc09d0
Compare
pradyunsg
force-pushed
the
cleanup-egg_info_path
branch
from
fcc09d0 to
f841076
Compare
pradyunsg
added
skip news
chrahunt
reviewed
Sep 25, 2019
pradyunsg
force-pushed
the
cleanup-egg_info_path
branch
from
f841076 to
78b4a30
Compare
Why: Allows reducing indentation of the function body.
Why: It makes it clearer what the funky expression means.
Why: A named function brings clarity to expressing what is happening.
pradyunsg
force-pushed
the
cleanup-egg_info_path
branch
from
78b4a30 to
618714b
Compare
chrahunt
approved these changes
Sep 25, 2019
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property has a very awkward lifecycle.
This PR cleans up how getter for this attribute works. I'll address the lifecycle in follow up PRs.