Skip to content

Made a minor version change from 2.2.0 to 2.3.1 in the documentation #7681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Made a minor version change from 2.2.0 to 2.3.1 in the documentation #7681

wants to merge 5 commits into from

Conversation

KoundinyaSi
Copy link

@KoundinyaSi KoundinyaSi commented Feb 2, 2020 •
edited
Loading

Fixes #7683

Please look into it

@KoundinyaSi KoundinyaSi requested a review from pradyunsg February 2, 2020 10:34
@pradyunsg pradyunsg mentioned this pull request Feb 2, 2020
Closed
uranusjr
uranusjr reviewed Feb 3, 2020
View reviewed changes
docs/html/development/getting-started.rst Outdated

Generally, it can take a long time to run pip's test suite. To run tests in parallel,
which is faster, run:
The version of tox given below also works in a similar way, although a bit slower than the version above
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it’s more than a bit slower, or a lot slower.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it’s more than a bit slower, or a lot slower.

Yeah you're right. Let me make these changes.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 28, 2020
@uranusjr
Copy link
Member

Duplicate to #7685.

@uranusjr uranusjr closed this Feb 28, 2020
@uranusjr
Copy link
Member

Oops, this contains a documentation change that’s not included in the title. @Koundinya-noob could you help remove the sphinx version upgrade and rename the PR, so this can be merged?

@uranusjr uranusjr reopened this Feb 28, 2020
@pradyunsg
Copy link
Member

Pinging @Koundinya-noob, in case they're still interested.

@deveshks
Copy link
Contributor

deveshks commented Apr 3, 2020

Hi @pradyunsg , @uranusjr

The changes in this PR are already addressed in commits as follows:

  1. Suggestion to run parallel tests is already pushed in commit 69cc558
    and PR Rephrases documentation #7878

  2. Sphinx has been upgraded to 2.4.3 in the docs in commit 07d2966 and PR Updated sphinx to 2.4.0 #7720, which is >= 2.3.1, the version mentioned in the PR.

So this PR can be closed.

@pradyunsg pradyunsg closed this Apr 3, 2020
@uranusjr uranusjr mentioned this pull request Apr 16, 2020
Merged
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr left review comments

@pradyunsg pradyunsg Awaiting requested review from pradyunsg

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation needs rebase or merge PR has conflicts with current master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop suggesting the single-threaded variant for running tests
5 participants
@KoundinyaSi @BrownTruck @uranusjr @pradyunsg @deveshks