Skip to content

Rephrases documentation #7878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 25, 2020
Merged

Rephrases documentation #7878

merged 7 commits into from
Mar 25, 2020

Conversation

onlinejudge95
Copy link

Fixes #7683

uranusjr
uranusjr requested changes Mar 21, 2020
View reviewed changes
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One typo needs fixing; others are comments based on personal preferences.

@onlinejudge95 onlinejudge95 requested a review from uranusjr March 21, 2020 08:16
@onlinejudge95 onlinejudge95 requested a review from pradyunsg March 21, 2020 08:59
@onlinejudge95
Copy link
Author

@pradyunsg how do I get the waiting and expecting tests to run, as for the travis check I am seeing the status as passing in the link. Which is not yet reflected in GitHub.

@pradyunsg pradyunsg closed this Mar 23, 2020
@pradyunsg pradyunsg reopened this Mar 23, 2020
@pradyunsg
Copy link
Member

pradyunsg commented Mar 23, 2020 •
edited
Loading

Closing and reopening retriggers the CI setup. All the tests run again but that's the best way to handle mis-reported CI.

@onlinejudge95
Copy link
Author

Strange now I have certain tests failing that were passing earlier, that too without any code diff 😕

@uranusjr
Copy link
Member 

InvalidHeader: Invalid Retry-After header: 1m0s

Network issues. I believe we can safely ignore that.

@pradyunsg
Copy link
Member

Restarted just those tests.

pradyunsg
pradyunsg reviewed Mar 24, 2020
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments; LGTM otherwise.

pradyunsg
pradyunsg reviewed Mar 24, 2020
View reviewed changes
@pradyunsg pradyunsg added skip news Does not need a NEWS file entry (eg: trivial changes) type: docs Documentation related labels Mar 24, 2020
@onlinejudge95 onlinejudge95 requested a review from pradyunsg March 24, 2020 14:03
@onlinejudge95
Copy link
Author

@uranusjr any help

@uranusjr
Copy link
Member

@onlinejudge95 Not from me, I don’t have the permission to merge :) Be patient.

@pfmoore
Copy link
Member

pfmoore commented Mar 25, 2020

@onlinejudge95 Thanks for the contribution!

@pfmoore pfmoore merged commit 69cc558 into pypa:master Mar 25, 2020
@pradyunsg pradyunsg removed their request for review March 25, 2020 08:26
@McSinyx McSinyx mentioned this pull request Mar 29, 2020
Merged
@deveshks deveshks mentioned this pull request Apr 3, 2020
Closed
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Apr 25, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg left review comments

@uranusjr uranusjr uranusjr approved these changes

@pfmoore pfmoore pfmoore approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: docs Documentation related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop suggesting the single-threaded variant for running tests
4 participants
@onlinejudge95 @pradyunsg @uranusjr @pfmoore