-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Rely on SPDX identifier for license #4975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`contextlib.chdir` isn't available until Python 3.11.
There is a (mildly heated) debate in https://discuss.python.org/t/split-from-pep-639-expressing-project-vs-distribution-licenses-post-pep-639-mod-titled/90314 regarding the vendoring use case and the license expressions. According to that discussion the This means that for setuptools it would have to be something in the shape of Because we don't have any tool in the ecosystem yet to calculate that automatically that we can add to the vendoring script, this would add maintenance burden, because we would need to manually craft or at least verify the license expression every time we update the vendored dependencies). I mentioned in the thread two different approaches that we could follow (and no one said they would be "wrong" so far):
This is currently a limitation of the standard (it covers simple projects but edge cases that involve vendoring are not easy to deal with). @jaraco do you have thoughts on it? Footnotes |
My opinion - it's a lot of hand wringing over nothing. I don't have time to read, much less synthesize that long conversation. Paul makes a good point that the current system is unable to accurately and generally reflect the truth of the matter (what licenses are applicable for which lines of code). It's already enough overhead to deal with multiple declarations of potentially inconsistent license declarations in simple projects without vendored dependencies, I am strongly opposed to creating mashups of entangled licenses. The industry has already accepted that licenses don't need to be included in every file and that copyrights don't need to be included in every file and every license. Let's just do our best to communicate the truth of the matter, that Setuptools is licensed as MIT, the copyrights are implied, and vendored packages are licensed per their project licenses. If someone needs clarity, we can do that out of band, but let's keep the SPDX identifier clean and straightforward and not confuse matters by blending them together. If they want to insist that vendoring a package requires somehow absorbing their license, that's going to be enough motivation to just remove the vendored packages (which incidentally, I'm getting close to having a technique that may unlock that without breaking bootstrapping). |
Summary of changes
Closes #4956
Pull Request Checklist
newsfragments/
.(See documentation for details)