Remove unused dependency on coherent.licensed
#5003
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Anderson for this. See my note in the issue for why I'm hesitant to simply remove the dependency. |
Elenore23
approved these changes
May 19, 2025
|
Let's go ahead and apply this change here (only) for now to alleviate the concern for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
With the changes introduced in ae480ff, the dependency on
coherent.licensedis unused, so I think it would be good to remove it for clean-up purposes1.The approach I took here was to simply comment out the line, because I notice that is the approach previously used in #4975, but I can also simply remove all the
requiresand put an empty array if that is preferred.Closes #5002
Pull Request Checklist
newsfragments/.(See documentation for details)
Footnotes
The removal should speed up build and facilitate for downstream consumers building from git repos instead of sdists.
I understand that in the long run it would be nice to have a solution for the cycles, but for now because we are not using the dependency, there is not much point in keep it around. ↩