-
Notifications
You must be signed in to change notification settings - Fork 1k
Test development setup with GitHub Actions #10052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please approve the workflow, somebody. |
79a1dcd
to
5ed8522
Compare
@di @ewdurbin @ewjoachim guys, can you approve tests and give this PR some reviews? |
I cannot. Well I can review it but given I'm not a maintainer, so this won't change a thing. The project moves at the pace that the maintainers can afford to spend on it. Sometimes it moves a lot, and sometimes, there are other priorities. It's just like that, sorry :) Also, please don't assume everyone is a guy ;) |
@ewjoachim I've checked my sources - https://www.washingtonpost.com/outlook/2021/07/07/guys-defense-gendered-etymology/ - it is okay. ) |
Ah, then, if the Washington post has issued an article stating that me and the other people you mentioned were ok with being addressed as "guys", then what can I say ;) (Can't recall when the journalist asked me though 🤔) Sarcasm aside, I'm doing my very best to try and help you here, but doubling down when a friendly advice is given might not be the strategy that will lead to the most satisfying outcome for all parties involved. |
@ewjoachim I can relate to that people in power or under pressure may not do the thing that they are expected to do if they are not being approached in the way they like. Happened to me more than once. If you're saying that it might be the case here, then I am forced to oblige that "guys" is not an appropriate word and give my apologies. ) @ewjoachim D&I issues aside, why don't "they" give you the privileges to merge requests or at least unblock workflows? |
7fd08b8
to
b509d4e
Compare
37c1f2f
to
a29161d
Compare
a29161d
to
d46397b
Compare
Rebased. Still waiting for review. |
@ewjoachim so how you would turn attention from the PSF sponsored devs to this PR without using the word "guys"? |
So, peeps, how about getting this PR a review? |
I am going to rebase this to troubleshoot if my broken local build for #9972 repeats on newer code. For the reference Dev Setup after the last rebase took 16m 30s. Dev Setup #7 - https://github.com/pypa/warehouse/actions/runs/1378501108 |
d46397b
to
dea369e
Compare
Okay, the development setup is broken again on
|
This removes circular dependency in Makefile added in pypi#10278 Unblocks pypi#10052 Fixes pypi#10446 Fixes pypi#10447
This removes circular dependency in Makefile added in pypi#10278 Unblocks pypi#10052 Fixes pypi#10446 Fixes pypi#10447
This removes circular dependency in Makefile added in pypi#10278 Unblocks pypi#10052 Fixes pypi#10446 Fixes pypi#10447
dea369e
to
237b7c4
Compare
237b7c4
to
f3f5997
Compare
Add healthcheck to docker-compose.yml Add a script to wait for DB healthcheck to pass Stop waiting for DB after 1 minute
f3f5997
to
08f5de5
Compare
Exercise some of our `Makefile`, `docker-compose.yml` and shell script wrapper utilities. Originally conceived in pypi#10052, simplified with current commands. Closes pypi#10052 Signed-off-by: Mike Fiedler <[email protected]>
* test: run the development environment steps in CI Exercise some of our `Makefile`, `docker-compose.yml` and shell script wrapper utilities. Originally conceived in #10052, simplified with current commands. Closes #10052 Signed-off-by: Mike Fiedler <[email protected]> * Add a start_period to the db healthcheck Allow some time for the database to start up before performing "real" readiness checks. If the service is ready (healthcheck test command passes) during the start_period, it'll be considered healthy and continue. Refs: https://docs.docker.com/engine/reference/builder/#healthcheck:~:text=start%20period%20provides%20initialization%20time%20for%20containers%20that%20need,will%20be%20counted%20towards%20the%20maximum%20number%20of%20retries. Signed-off-by: Mike Fiedler <[email protected]> * only run on a schedule, and not part of PR/flow Signed-off-by: Mike Fiedler <[email protected]> --------- Signed-off-by: Mike Fiedler <[email protected]>
This adds a new workflow that sets up development environment and runs tests with
docker-compose
as described in getting started docs. This could be used to improve the setup time, which takes more than 10 minutes right now.https://github.com/abitrolly/warehouse/runs/3640554285?check_suite_focus=true