Run all dev actions in containers #10803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
force-pushed
the
fix/4948
branch
2 times, most recently
from
abffe45 to
c765102
Compare
ewjoachim
approved these changes
Feb 22, 2022
|
Everything seems to work except translations. I did a full purge/clean etc and |
|
Tests on dev still fail #10052 |
miketheman
added a commit
to miketheman/warehouse
that referenced
this pull request
Mar 20, 2022
When moving all development actions to containers in pypi#10803, this step remained outside on the host OS. As `xz-utils` are installed in the `web` image already, use those instead of relying on the host to install them. Refs: pypi#5872 Closes: pypi#5980 Signed-off-by: Mike Fiedler <[email protected]>
di
pushed a commit
that referenced
this pull request
Mar 20, 2022
When moving all development actions to containers in #10803, this step remained outside on the host OS. As `xz-utils` are installed in the `web` image already, use those instead of relying on the host to install them. Refs: #5872 Closes: #5980 Signed-off-by: Mike Fiedler <[email protected]>
domdfcoding
pushed a commit
to domdfcoding/warehouse
that referenced
this pull request
Jun 7, 2022
* Run docs build in container * Run translations build in container * Run depchecker in container * Run requirements build in container * Run license check in container * Clean up Makefile * Update docs * Remove unused COMMAND_ARGS, use double quotes * Add missing semicolons * Move github-actions-deps out of Makefile * Set ENCODING and PATH in dev/environment * Fix typo with translations build
domdfcoding
pushed a commit
to domdfcoding/warehouse
that referenced
this pull request
Jun 7, 2022
When moving all development actions to containers in pypi#10803, this step remained outside on the host OS. As `xz-utils` are installed in the `web` image already, use those instead of relying on the host to install them. Refs: pypi#5872 Closes: pypi#5980 Signed-off-by: Mike Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4948, fixes #10447. Closes #10469.