Fix config test: ignore all env vars in test environment #10835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except for WAREHOUSE_ENV
domdfcoding
pushed a commit
to domdfcoding/warehouse
that referenced
this pull request
Jun 7, 2022
* Remove unused other_settings param * Don't mutate original test param * Ignore all environment variables in the test env Except for WAREHOUSE_ENV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #10803 to remove the
env -iflag todocker-compose runin favor of moving these variables into thedev/environmentfile instead had the effect of inserting all environment variables indev/environmentinto the test environment when run viamake testsThis didn't affect any tests except for
test_config, which was making assumptions about what environment variables were present in the test environment. To remedy this, we make the test explicitly ignore all environment variables in the test environment to restore it's intended behavior.Also cleans up the test a bit.