Skip to content

GitHub Actions CI #8255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

callmecampos
Copy link
Contributor

@callmecampos callmecampos commented Jul 13, 2020

Testing Warehouse using GitHub Actions. We run all of our jobs in parallel using the native ubuntu-latest Docker containers provided by GitHub Actions.

Resolves #7001. You can see the latest runs with runtimes at the bottom of this PR, or in the Checks tab.

This won't yet be able to run on pypa/warehouse since the secret environment variables for Docker Hub haven't been set up in this repo, only in my fork. This now runs fine on pypa/warehouse.

@di di self-requested a review July 13, 2020 21:38
@callmecampos callmecampos force-pushed the github-actions-ci branch 21 times, most recently from 8d30825 to 0e9895b Compare July 14, 2020 19:09
@pavanagrawal123
Copy link

hey @callmecampos, this looks really good! I had #7881 open for this, but I didn't have much time recently to fix it up. This is a way better approach then I had going. I'm going to close #7881 in favor of this!

@callmecampos callmecampos force-pushed the github-actions-ci branch 7 times, most recently from 8529fd5 to 7eccd3f Compare July 20, 2020 16:45
@callmecampos callmecampos force-pushed the github-actions-ci branch 12 times, most recently from 8ccd126 to 0435f61 Compare August 14, 2020 06:09
Copy link
Contributor Author

@callmecampos callmecampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@di tested out and made the changes you requested

@callmecampos callmecampos force-pushed the github-actions-ci branch 2 times, most recently from 4d39e9a to fec28a2 Compare August 14, 2020 17:38
@callmecampos callmecampos requested a review from di August 14, 2020 17:57
@di di mentioned this pull request Sep 9, 2020
@webknjaz
Copy link
Member

@callmecampos Most (if not all) of the jobs here can be collapsed into a nice matrix. Are there any reasons for not implementing this?

@@ -0,0 +1,272 @@
name: CI

on: [push, pull_request]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding a cron schedule here would be nice too

Comment on lines 5 to 7
env:
PYTHON_VERSION: 3.8.2
NODE_VERSION: 14.4.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be necessary if you make a matrix...

@di
Copy link
Member

di commented Sep 17, 2020

Hey @webknjaz, @callmecampos was working on this as part of his internship which is now finished. Would you like to take over here?

@webknjaz
Copy link
Member

@di ah, I didn't know. If he is not going to keep working on this PR, I'll try to find some time myself, but no promises.

Base automatically changed from master to main January 21, 2021 18:39
@di di force-pushed the github-actions-ci branch from cb567b4 to 2b5549e Compare February 12, 2021 06:36
@di di mentioned this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look at using GitHub Actions for CI
4 participants