-
Notifications
You must be signed in to change notification settings - Fork 1k
GitHub Actions CI #8255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions CI #8255
Conversation
8d30825
to
0e9895b
Compare
hey @callmecampos, this looks really good! I had #7881 open for this, but I didn't have much time recently to fix it up. This is a way better approach then I had going. I'm going to close #7881 in favor of this! |
8529fd5
to
7eccd3f
Compare
8ccd126
to
0435f61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@di tested out and made the changes you requested
4d39e9a
to
fec28a2
Compare
fec28a2
to
19619d2
Compare
@callmecampos Most (if not all) of the jobs here can be collapsed into a nice matrix. Are there any reasons for not implementing this? |
.github/workflows/main.yml
Outdated
@@ -0,0 +1,272 @@ | |||
name: CI | |||
|
|||
on: [push, pull_request] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding a cron schedule here would be nice too
.github/workflows/main.yml
Outdated
env: | ||
PYTHON_VERSION: 3.8.2 | ||
NODE_VERSION: 14.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't be necessary if you make a matrix...
Hey @webknjaz, @callmecampos was working on this as part of his internship which is now finished. Would you like to take over here? |
@di ah, I didn't know. If he is not going to keep working on this PR, I'll try to find some time myself, but no promises. |
cb567b4
to
2b5549e
Compare
Testing Warehouse using GitHub Actions. We run all of our jobs in parallel using the native
ubuntu-latest
Docker containers provided by GitHub Actions.postgres:10.1
instead ofpostgres:latest
.Ideally we would cache Docker containers with GitHub Package Registry instead of Docker Hub (because of faster build time when compared to other caching methods), however it doesn't yet seem possible to use for container actions because accessing even public packages on GitHub Package Registry requires an extra authentication step (see https://github.community/t/docker-pull-from-public-github-package-registry-fail-with-no-basic-auth-credentials-error/16358 for ongoing discussion). In case GitHub fixes this and allows a simpler integration of Actions and Package Registry, I've left the (skipped) job in .github/workflows/main.yml.test
,lint
,deps
,static-tests
,static-pipeline
.Resolves #7001. You can see the latest runs with runtimes at the bottom of this PR, or in the Checks tab.
This won't yet be able to run on pypa/warehouse since the secret environment variables for Docker Hub haven't been set up in this repo, only in my fork.This now runs fine on pypa/warehouse.