Skip to content

GitHub Actions #9083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 12, 2021
Merged

GitHub Actions #9083

merged 8 commits into from
Mar 12, 2021

Conversation

di
Copy link
Member

@di di commented Feb 12, 2021

Fixes #7001, closes #8255, closes #4961.

@di di requested a review from ewdurbin February 12, 2021 08:05
@di di force-pushed the github-actions-ci branch 4 times, most recently from 1773470 to 38d6df3 Compare February 12, 2021 23:08
@ewdurbin
Copy link
Member

My only concern here is that the check with the busted git command... still went green?

Are we doing something wrong that an error like that doesn't surface? Could lead to some broken ships.

@di di force-pushed the github-actions-ci branch from 38d6df3 to d5d0347 Compare February 20, 2021 05:32
@di
Copy link
Member Author

di commented Feb 20, 2021

My only concern here is that the check with the busted git command... still went green?

Are we doing something wrong that an error like that doesn't surface? Could lead to some broken ships.

The current command just assumes that the git diff will always succeed. I added a guard in 638e263 just to be safe.

@di di force-pushed the github-actions-ci branch from 9af570b to a40a042 Compare February 20, 2021 05:51
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM unless you want to do some polishing

@di di requested review from ewdurbin and removed request for ewdurbin March 11, 2021 19:25
@ewdurbin
Copy link
Member

Thank you @di and @webknjaz!

@ewdurbin ewdurbin merged commit 961575f into main Mar 12, 2021
@ewdurbin ewdurbin deleted the github-actions-ci branch March 12, 2021 16:10
@di di mentioned this pull request Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look at using GitHub Actions for CI
4 participants