-
Notifications
You must be signed in to change notification settings - Fork 1k
GitHub Actions #9083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions #9083
Conversation
1773470
to
38d6df3
Compare
My only concern here is that the check with the busted git command... still went green? Are we doing something wrong that an error like that doesn't surface? Could lead to some broken ships. |
38d6df3
to
d5d0347
Compare
The current command just assumes that the |
9af570b
to
a40a042
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM unless you want to do some polishing
Fixes #7001, closes #8255, closes #4961.