Skip to content

use a test runner that is declared in settings #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

slafs
Copy link

@slafs slafs commented Feb 4, 2014

In "Django>1.6" i noticed a small warning about deprecation of django.test.simple.DjangoTestSuiteRunner. I think this PR fixes this.

@julen julen mentioned this pull request Apr 11, 2014
@pelme
Copy link
Member

pelme commented Apr 13, 2014

Thanks for the PR!

I have restructured the code a bit to avoid django.test.simple.DjangoTestSuiteRunner, which should make pytest-django run on both 1.7 and 1.8.

It does not really make sense to be able to configure the test runner when using pytest-django, since you are then not using Django's test runner anymore. :-) It was historically used within pytest-django since some of the test environment setup was done there. Starting with Django 1.6, that is no longer needed.

If you have a real use case for having the runner configurable, please open a new issue or PR.

@pelme pelme closed this Apr 13, 2014
@slafs
Copy link
Author

slafs commented Apr 13, 2014

No :). Just wanted to get rid of deprecation warnings about using an old test runner ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants