Travis: also test on MyISAM

[julen]

Haven't had a chance to actually try this, let's hear from Travis-CI itself...

Also: I'm not sure what MySQL version Travis-CI runs on, it only mentions 5.5.x, but the fact is that InnoDB became the default only in 5.5.5.

[julen]

The build failures are related to:

• The MySQL connector (MySQL-python) not supporting Python 3.2/3.3. The alternative looks like using PyMySQL. I can change this in the .travis.yml file.
• Django 1.7 support (basically fixing use a test runner that is declared in settings #66, or at the very least trying to use django.test.runner.DiscoverRunner first before falling back to django.test.simple.DjangoTestSuiteRunner)

[julen]

I talked too fast about PyMySQL, since it's not compatible with Django these days. I'll restore the excludes.

[pelme]

Thanks for tackling this.

Can you please update this PR to the latest master, it should probably take care of all the failures seen on Travis.

[julen]

There you go.

[pelme]

Thanks! It looks like the exclusion rules will need to be updated too, to exclude Django master+Python 2.6.

[julen]

I just did it, actually — OTOH it's worth noting that master is 1.8 already, but since 1.7 is not available on PyPi yet it's now untested.

[pelme]

Thanks, I was very confused for a minute when I saw a new build on Travis at the same time as my comment. :)

Yes, we should add the 1.7 beta tar ball until 1.7 hits PyPI. The build matrix is getting huge and a bit tedious to manage, but I think it should work.

[pelme]

It is strange that the build does not fail on MyISAM though, are you sure the init_command option is not needed? The pytest_django and pytest_django_reuse database are mostly created to workaround https://code.djangoproject.com/ticket/16969

[julen]

No, I'm not sure :) TBH at this stage I ignore how the DB initialization process works.

I can adapt the patch to use separate settings files for InnoDB and MyISAM and issue the init_command from there, passing the relevant SET STORAGE_ENGINE=<XYZ> there. How does that sound?

[pelme]

That sounds like a good idea!

[julen]

Done, hopefully this makes more sense. Also, you could maybe accelerate getting the results by cancelling old/obsolete test runs.

[pelme]

Thanks, I cancelled build 225 now.

[pelme]

Now there are some failures on MyISAM. :)

I think it would be good to have all MyISAM changes in this branch, so that we can ensure it all works before merging to master.

It looks like some other tests that deals with transactions needs to be skipped on MyISAM too.

[julen]

Cherry-picked changes from #64.

I'm not sure how to tell @pytest.mark.skipif() that MyISAM is being used without coupling the tests to be skipped to the Travis setup. Any ideas?

[pelme]

There is a "connections_support_transactions" that can be used.
https://github.com/django/django/blob/master/django/test/testcases.py#L850

Something like

from django.test.testcases import connections_support_transactions

def test_that_needs_transactions():
    if not connections_support_transactions():
        pytest.skip('transactions required for this test')

    # ...

could work.

[julen]

Thanks! Locally works fine; let's see what Travis says...

[pelme]

Thanks a lot for putting in the effort to fix this! I have merged all the changes, and Travis is building everything in the master branch now!

[julen]

Thanks to you for keeping pytest-django alive!

Just wondering: any blockers for a next release on PyPI? Maybe you want to ensure Django 1.7 support before that happens?

[pelme]

No blockers. I am just going crazy of the explosion of combinations in Travis. I want to make sure Django 1.7 and Python 3.4 are tested+fully supported before the release.

I making a script to generate tox.ini+.travis.yml for all valid, supported versions. I also want to be able to run things locally since Travis takes ages.

Anyways, I hope to get a new version on PyPI during the week.

[julen]

That sounds great, and thanks for the effort!