Skip to content

Specialization of member descriptors only handles Py_T_OBJECT_EX but _Py_T_OBJECT seems more common #111772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markshannon opened this issue Nov 6, 2023 · 0 comments
Closed

Specialization of member descriptors only handles Py_T_OBJECT_EX but _Py_T_OBJECT seems more common #111772

markshannon opened this issue Nov 6, 2023 · 0 comments
Labels
performance Performance or resource usage

Comments

@markshannon
Copy link
Member

markshannon commented Nov 6, 2023 •
edited by bedevere-app bot
Loading

Despite _Py_T_OBJECT being marked as deprecated in descrobject.h it is commonly used in the standard library.
LOAD_ATTR_SLOT de-optimizes if the stored value is NULL. If the stored value is not NULL, both _Py_T_OBJECT and Py_T_OBJECT_EX act the same, so we can reuse LOAD_ATTR_SLOT for _Py_T_OBJECT.

For storing attributes, _Py_T_OBJECT and Py_T_OBJECT_EX are exactly the same.

I don't know why _Py_T_OBJECT is deprecated, the semantics seem quite reasonable.

Linked PRs
@markshannon markshannon added the performance Performance or resource usage label Nov 6, 2023
@bedevere-app bedevere-app bot mentioned this issue Nov 6, 2023
Merged
markshannon added a commit that referenced this issue Nov 6, 2023
@markshannon
GH-111772: Specialize slot loads and stores for _Py_T_OBJECT (GH-11…
a7b0f63 
…1773)
hugovk pushed a commit to hugovk/cpython that referenced this issue Nov 8, 2023
@markshannon @hugovk
pythonGH-111772: Specialize slot loads and stores for _Py_T_OBJECT (p…
e207b2c 
…ythonGH-111773)
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@markshannon @aisk
pythonGH-111772: Specialize slot loads and stores for _Py_T_OBJECT (p…
6b488ce 
…ythonGH-111773)
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@markshannon @Glyphack
pythonGH-111772: Specialize slot loads and stores for _Py_T_OBJECT (p…
d1b44ff 
…ythonGH-111773)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Performance or resource usage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@markshannon