Skip to content

GH-111772: Specialize slot loads and stores for _Py_T_OBJECT #111773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Nov 6, 2023

Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no tests for these things?

@markshannon
Copy link
Member Author

There is the implicit test of every use of every relevant attribute.
That seems to be enough for the tier 1 specialization.

@markshannon markshannon merged commit a7b0f63 into python:main Nov 6, 2023
hugovk pushed a commit to hugovk/cpython that referenced this pull request Nov 8, 2023
@markshannon markshannon deleted the better-specialize-load-slot branch August 6, 2024 10:17
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants