Skip to content

Warnings and errors specific to the C implementation of the warnings module #122255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
serhiy-storchaka opened this issue Jul 25, 2024 · 1 comment
Open

Warnings and errors specific to the C implementation of the warnings module #122255

serhiy-storchaka opened this issue Jul 25, 2024 · 1 comment
Labels
topic-importlib

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jul 25, 2024 •
edited by bedevere-app bot
Loading

New deprecation warnings about missing or inconsistent __spec__.loader and __loader__ introduced in #86298 are emitted only for the C implementation of the warnings module. Existing errors (AttributeError or ValueError) are also only raised for the C implementation of the warnings module. See tests added in #122227.

I believe that before turning the deprecation warnings into errors, we should add warnings for the Python implementation.

cc @brettcannon, @warsaw

Linked PRs
@serhiy-storchaka serhiy-storchaka mentioned this issue Jul 25, 2024
Closed
@bedevere-app bedevere-app bot mentioned this issue Aug 8, 2024
Merged
serhiy-storchaka added a commit that referenced this issue Aug 8, 2024
@serhiy-storchaka
gh-122255: Add black box tests in test_warnings (GH-122227)
fe13c9b 
They are similar to white box tests for gh-86298 in test_importlib.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 8, 2024
@serhiy-storchaka @miss-islington
pythongh-122255: Add black box tests in test_warnings (pythonGH-122227)
6126b60 
They are similar to white box tests for pythongh-86298 in test_importlib.
(cherry picked from commit fe13c9b)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Aug 8, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 8, 2024
@serhiy-storchaka @miss-islington
pythongh-122255: Add black box tests in test_warnings (pythonGH-122227)
2ed027a 
They are similar to white box tests for pythongh-86298 in test_importlib.
(cherry picked from commit fe13c9b)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Aug 8, 2024
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Aug 8, 2024
@serhiy-storchaka
pythongh-122255: Synchronize warnings in C and Python implementations…
ad53fe3 
… of the warnings module

In the linecache module and in the Python implementation of the
warnings module, a DeprecationWarning is issued when
m.__loader__ differs from m.__spec__.loader (like in the C
implementation of the warnings module).
@bedevere-app bedevere-app bot mentioned this issue Aug 8, 2024
Open
gpshead pushed a commit that referenced this issue Aug 9, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-122255: Add black box tests in test_warnings (GH-122227) (G…
46f973f 
…H-122818)

gh-122255: Add black box tests in test_warnings (GH-122227)

They are similar to white box tests for gh-86298 in test_importlib.
(cherry picked from commit fe13c9b)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka
Copy link
Member Author

Tests are failed for this change, and I think this is because it exposes a flaw in the current code. Opened #123011.

serhiy-storchaka added a commit that referenced this issue Aug 14, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-122255: Add black box tests in test_warnings (GH-122227) (G…
c3ee1a7 
…H-122819)

They are similar to white box tests for gh-86298 in test_importlib.
(cherry picked from commit fe13c9b)

Co-authored-by: Serhiy Storchaka <[email protected]>
blhsing pushed a commit to blhsing/cpython that referenced this issue Aug 22, 2024
@serhiy-storchaka @blhsing
pythongh-122255: Add black box tests in test_warnings (pythonGH-122227)
d591fcd 
They are similar to white box tests for pythongh-86298 in test_importlib.
@hugovk hugovk mentioned this issue Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-importlib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka