gh-122255: Synchronize warnings in C and Python implementations of the warnings module #122824
+81
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the warnings module In the linecache module and in the Python implementation of the warnings module, a DeprecationWarning is issued when m.__loader__ differs from m.__spec__.loader (like in the C implementation of the warnings module).
vstinner
reviewed
Sep 20, 2024
| @@ -0,0 +1,4 @@ | |||
| In the :mod:`linecache` module and in the Python implementation of the | |||
| :mod:`warnings` module, a ``DeprecationWarning`` is issued when | |||
| ``m.__loader__`` differs from ``m.__spec__.loader`` (like in the C | |||
There was a problem hiding this comment.
Suggested change
| ``m.__loader__`` differs from ``m.__spec__.loader`` (like in the C | |
| ``mod.__loader__`` differs from ``mod.__spec__.loader`` (like in the C |
| return False | ||
|
|
||
| if module_globals is not None and not isinstance(module_globals, dict): | ||
| raise TypeError(f'module_globals must be a dict, not {type(module_globals).__name__}') |
There was a problem hiding this comment.
Suggested change
| raise TypeError(f'module_globals must be a dict, not {type(module_globals).__name__}') | |
| raise TypeError(f'module_globals must be a dict, not {type(module_globals).__qualname__}') |
|
Failed tests show that we may reconsider this deprecation. |
vstinner
approved these changes
Sep 24, 2024
| DeprecationWarning) | ||
| return loader | ||
|
|
||
| assert spec_loader is not None |
There was a problem hiding this comment.
This assertion looks redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the linecache module and in the Python implementation of the warnings module, a DeprecationWarning is issued when
m.__loader__differs fromm.__spec__.loader(like in the C implementation of the warnings module).