Skip to content

Support command history in PyREPL on Windows #122273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
devdanzin opened this issue Jul 25, 2024 · 2 comments
Closed

Support command history in PyREPL on Windows #122273

devdanzin opened this issue Jul 25, 2024 · 2 comments
Labels
OS-windows topic-repl Related to the interactive shell type-feature A feature request or enhancement

Comments

@devdanzin
Copy link
Contributor

devdanzin commented Jul 25, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

The new PyREPL doesn't currently support recording command history in Windows. Using the _pyrepl.readline module, it should be possible to save and load history files on that platform.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs
@devdanzin devdanzin added the type-feature A feature request or enhancement label Jul 25, 2024
@bedevere-app bedevere-app bot mentioned this issue Jul 25, 2024
Closed
@hugovk hugovk added OS-windows topic-repl Related to the interactive shell labels Jul 25, 2024
vstinner added a commit to vstinner/cpython that referenced this issue Nov 22, 2024
@vstinner @devdanzin
pythongh-122273: Fix PyREPL history on Windows
e8d3af0 
Co-Authored-By: devdanzin <[email protected]>
vstinner added a commit to vstinner/cpython that referenced this issue Nov 22, 2024
@vstinner @devdanzin
pythongh-122273: Fix PyREPL history on Windows
2c02efc 
Co-Authored-By: devdanzin <[email protected]>
vstinner added a commit to vstinner/cpython that referenced this issue Nov 22, 2024
@vstinner @devdanzin
pythongh-122273: Support PyREPL history on Windows
7a6c846 
Co-Authored-By: devdanzin <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Nov 22, 2024
Merged
vstinner added a commit that referenced this issue Nov 26, 2024
@vstinner @devdanzin
gh-122273: Support PyREPL history on Windows (#127141)
3c7a90a 
Co-authored-by: devdanzin <[email protected]>
vstinner added a commit to vstinner/cpython that referenced this issue Nov 26, 2024
@vstinner @devdanzin
pythongh-122273: Support PyREPL history on Windows (python#127141)
167ac1b 
Co-authored-by: devdanzin <[email protected]>
(cherry picked from commit 3c7a90a)
@bedevere-app bedevere-app bot mentioned this issue Nov 26, 2024
Merged
vstinner added a commit that referenced this issue Nov 26, 2024
@vstinner @devdanzin
[3.13] gh-122273: Support PyREPL history on Windows (#127141) (#127289)
a5741d6 
gh-122273: Support PyREPL history on Windows (#127141)

Co-authored-by: devdanzin <[email protected]>
(cherry picked from commit 3c7a90a)
@vstinner
Copy link
Member

Thanks @devdanzin for your bug report and your fix!

@vstinner vstinner mentioned this issue Nov 28, 2024
Closed
@vstinner
Copy link
Member

I closed #125154 as a duplicate of this issue.

ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@vstinner @devdanzin @ebonnal
pythongh-122273: Support PyREPL history on Windows (python#127141)
691e84c 
Co-authored-by: devdanzin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-windows topic-repl Related to the interactive shell type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vstinner @hugovk @devdanzin