-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-122273: Support PyREPL history on Windows #127141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: devdanzin <[email protected]>
except ImportError: | ||
readline = None | ||
else: | ||
import rlcompleter # noqa: F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this import ever fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. In case of doubt, I prefer to keep the old behavior: catch and ignore ImportError.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Windows 11 with PowerShell and cmd.exe, works as intended.
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @vstinner, I could not cleanly backport this to
|
Co-authored-by: devdanzin <[email protected]> (cherry picked from commit 3c7a90a)
GH-127289 is a backport of this pull request to the 3.13 branch. |
Merged, thanks for the review @ambv. |
|
|
Co-authored-by: devdanzin <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.