-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-116869: Add test_cext test: build a C extension #116954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Once my fix PR gh-116950 will be merged, I will write a second change on top of this issue to run tests with |
Oh, the test catched a warning when using
I wrote PR #116963 to fix it. |
PR rebased on top of PR #116963 merged. |
# gh-110119: pip does not currently support 't' in the ABI flag use by | ||
# --disable-gil builds. Once it does, we can remove this skip. | ||
@unittest.skipIf(support.Py_GIL_DISABLED, | ||
'test does not work with --disable-gil') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should work now that #116878 landed!
(The comment was a bit inaccurate: it turns out the issue was in wheel
, not pip
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great! I will write a follow-up to patch also test_cppext
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR #116973
Merged. Let's start with something simple. |
Uh oh!
There was an error while loading. Please reload this page.