gh-116869: Enable test_cext and test_cppext on Free Threading build #116973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!buildbot nogil |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 98ff887 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
Thanks, I planned to do it, but waited for the first basic checks to make sure that I didn't mess up anything :-) |
colesbury
reviewed
Mar 18, 2024
Lib/test/test_cext/__init__.py
Outdated
Comment on lines
21
to
23
| @unittest.skipIf( | ||
| '-fsanitize' in (sysconfig.get_config_var('PY_CFLAGS') or ''), | ||
| 'test does not work with analyzing builds') |
There was a problem hiding this comment.
You can probably use support.skip_if_sanitizer(...) here
…uild Remove the "if Py_GIL_DISABLED" skip and move all "skip" decorators to the class.
vstinner
force-pushed
the
enable_test_cext_gil_disabled
branch
from
98ff887 to
1a3a98b
Compare
|
Oh, I had to rebase this PR to retrieve the WASI build fix. |
vstinner
added a commit
to vstinner/cpython
that referenced
this pull request
Mar 20, 2024
…uild (python#116973) Remove the "if Py_GIL_DISABLED" skip and move all "skip" decorators to the class. Use support.check_sanitizer()
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…uild (python#116973) Remove the "if Py_GIL_DISABLED" skip and move all "skip" decorators to the class. Use support.check_sanitizer()
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…uild (python#116973) Remove the "if Py_GIL_DISABLED" skip and move all "skip" decorators to the class. Use support.check_sanitizer()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the "if Py_GIL_DISABLED" skip and move all "skip" decorators to the class.