gh-118272: Clear generator frame's locals when the generator is closed #118277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
added
type-bug
graingert
reviewed
Apr 25, 2024
Co-authored-by: Thomas Grainger <[email protected]>
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @iritkatriel, I could not cleanly backport this to |
markshannon
reviewed
May 1, 2024
| _PyFrame_ClearLocals(_PyInterpreterFrame *frame) | ||
| { | ||
| assert(frame->stacktop >= 0); | ||
| for (int i = 0; i < frame->stacktop; i++) { |
There was a problem hiding this comment.
I think frame->stacktop = 0; needs to come before the loop to prevent the GC seeing freed objects.
There was a problem hiding this comment.
Let me make a fix for that. NM, approved gh-118478 instead.
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
… closed (python#118277) Co-authored-by: Thomas Grainger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118272.
Co-authored-by: Thomas Grainger [email protected]