gh-125723: Fix crash with f_locals when generator frame outlive their generator #126956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ncoghlan |
Eclips4
reviewed
Nov 18, 2024
Co-authored-by: Kirill Podoprigora <[email protected]>
markshannon
approved these changes
Nov 22, 2024
|
So, this PR can be merged? Or there's something I should improve? |
|
I am planning to merge this in a couple of days if no one has objections. |
sobolevn
approved these changes
Jan 19, 2025
ncoghlan
approved these changes
Jan 20, 2025
Misc/NEWS.d/next/Core_and_Builtins/2024-11-18-12-17-45.gh-issue-125723.tW_hFG.rst
Outdated
Show resolved
Hide resolved
…e-125723.tW_hFG.rst Co-authored-by: Alyssa Coghlan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that this PR had a problem.
It provides incorrect clearing of generator frame locals without checking any another references on this frame.
In this PR we can see a more accurate way of clearing such a frame.