gh-130149: fix HMAC tests for some FIPS-only build bots #130788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!buildbot FIPS |
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit cc2fbe1 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130788%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
I'm pretty sure the tests will fail (because those build bots are already failing) but they shouldn't fail more |
|
So, the two failures are now back to what they were previously. Those two build bots were already failing but now |
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…#130788) Skips some HMAC tests for some FIPS-only build bots that do not have the underlying hash functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can just skip those tests on FIPS-only build bots. Currently, the Python implementation of HMAC was just delegating to any existing implementation, but some of them are not available at all (neither in OpenSSL nor as built-in modules).
So for now, Python implementation of HMAC is tested with OpenSSL hash functions instead.