Skip to content

gh-130149: fix HMAC tests for some FIPS-only build bots #130788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 34 additions & 14 deletions Lib/test/test_hmac.py
Original file line number Diff line number Diff line change
Expand Up @@ -566,32 +566,52 @@ def test_with_fallback(self):
cache.pop('foo')


class PyRFCTestCase(PyTestVectorsMixin, ThroughObjectMixin,
RFCTestCasesMixin, unittest.TestCase):
"""Python implementation of HMAC using hmac.HMAC()."""


class PyDotNewRFCTestCase(PyTestVectorsMixin, ThroughModuleAPIMixin,
RFCTestCasesMixin, unittest.TestCase):
"""Python implementation of HMAC using hmac.new()."""


@hashlib_helper.requires_hashlib()
class OpenSSLRFCTestCase(OpenSSLTestVectorsMixin, RFCTestCasesMixin,
unittest.TestCase):
"""OpenSSL implementation of HMAC."""
class RFCWithOpenSSLHashFunctionTestCasesMixin(RFCTestCasesMixin):

def __init_subclass__(cls, *args, **kwargs):
super().__init_subclass__(*args, **kwargs)

for name in cls.ALGORITHMS:
@property
@hashlib_helper.requires_hashlib()
@hashlib_helper.requires_hashdigest(name, openssl=True)
def func(self, *, __name=name): # __name needed to bind 'name'
return getattr(_hashlib, f'openssl_{__name}')
setattr(cls, name, func)


class PyRFCTestCase(PyTestVectorsMixin, ThroughObjectMixin,
RFCWithOpenSSLHashFunctionTestCasesMixin,
unittest.TestCase):
"""Python implementation of HMAC using hmac.HMAC().

The underlying hash functions are OpenSSL-based.
"""


class PyDotNewRFCTestCase(PyTestVectorsMixin, ThroughModuleAPIMixin,
RFCWithOpenSSLHashFunctionTestCasesMixin,
unittest.TestCase):
"""Python implementation of HMAC using hmac.new().

The underlying hash functions are OpenSSL-based.
"""


class OpenSSLRFCTestCase(OpenSSLTestVectorsMixin,
RFCWithOpenSSLHashFunctionTestCasesMixin,
unittest.TestCase):
"""OpenSSL implementation of HMAC.

The underlying hash functions are also OpenSSL-based."""


# TODO(picnixz): once we have a HACL* HMAC, we should also test the Python
# implementation of HMAC with a HACL*-based hash function. For now, we only
# test it partially via the '_sha2' module, but for completeness we could
# also test the RFC test vectors against all possible implementations.


class DigestModTestCaseMixin(CreatorMixin, DigestMixin):
"""Tests for the 'digestmod' parameter."""

Expand Down
Loading