[WIP] gh-132166: Add check in find_longest_match for checking if sequences are identical #132167
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
sobolevn
reviewed
Apr 6, 2025
picnixz
reviewed
Apr 6, 2025
Comment on lines
+4
to
+5
| It appears to fix issue when comparing two slightly different strings ends up | ||
| with waiting forever for the result. |
There was a problem hiding this comment.
Suggested change
| It appears to fix issue when comparing two slightly different strings ends up | |
| with waiting forever for the result. | |
| It appears to fix issue when comparing two slightly different strings ends up | |
| with waiting forever for the result. |
We should be more confident here. Does it fix the issue or not? if so, let's say it. Otherwise, let's not give tentative conclusions.
Comment on lines
+1
to
+3
| Add checking if sequences ``a[alo:ahi]`` and ``b[blo:bhi]`` are the same on the | ||
| beginning of the method find_longest_match in SequenceMatcher. For identical | ||
| sequences there is no reason to run whole logic when simple check can be done. |
There was a problem hiding this comment.
This NEWS should be summarized. I suggest something like (assumiong that the method is documented, if not use a plain
Add a fast path in :meth:`SequenceMatcher.find_longest_match
<difflib.SequenceMatcher.find_longest_match>` to handle the
case when ``a[alo:ahi] == b[blo:bhi]``.|
|
||
| # Check if both sequences are the same before executing rest of the | ||
| # method. | ||
| if a[alo:ahi] == b[blo:bhi]: |
There was a problem hiding this comment.
Is this covered in tests? if not, please add a test, otherwise no need to add a large one.
jurgenwigg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #132166 added checking if both sequences are identical at the beginning of the method
find_longest_matchinSequenceMatcherclass.SequenceMatcher.find_longest_match#132166