bpo-40321: Support HTTP response status code 308 in urllib.request #19588
Conversation
HTTP response status code 308 is defined in https://tools.ietf.org/html/rfc7538 to be the permanent redirect variant of 307 (temporary redirect).
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
Contributor Agreement has been signed in the mean time. |
|
@jschulenklopper, it seems that the bot can't find the contributor agreement. Can you check that the github name is the same that you've used on this PR? Thanks. |
Ah, the GitHub user name just wasn't included on the profile in b.p.o. Fixed now. |
|
I faced the error today and was surprised it is not already supported. I hope this is merged soon! 👍 |
|
@csabella @orsenthil, does anything need to be changed for this to get merged? I ran into this issue when using urllib today and would love to see a fix make it into the standard library eventually. I see the NEWS.d CI check failed - is that all that is blocking this? If so, I would be happy to add a blurb if @jschulenklopper is unavailable. |
Feel free to do so. I don't know where/how to do that, and I guess you figured that out already. Thanks. |
|
@jschulenklopper I put up a PR (jschulenklopper/cpython#2) that should add the relevant blurb file; if you merge that into your branch, it should get picked up by this PR. |
Add blurb for bpo-40321 fix
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Thanks @rolandcrosby - it's merged into my branch. But now you apparently need to sign the CLA or connect your GitHub account to the b.p.o. :-) Happened to me before as well. |
|
Haha, I should have known. I signed the CLA so this should be unblocked as soon as the bot updates the status. |
|
Any news on this PR? |
|
I don't think it's blocked on anything at the moment. Not sure who can merge it. |
|
The "CLA not signed" label is still applied, so if @rolandcrosby did sign the CLA indeed, the bot needs to update the status. Not sure how to trigger that thing... Other than that, it seems that it can be (automatically) merged by project collaborators. |
|
Just added a note to the bpo issue to ask if any humans can fix the CLA status and help move this along. |
|
Hi Roland, Thanks for the ping. I will review and merge this. |
|
Sorry, I can't merge this PR. Reason: |
|
@orsenthil: Please replace |
orsenthil
added
needs backport to 3.9
|
Thanks @jschulenklopper for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Thanks @jschulenklopper for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
GH-28750 is a backport of this pull request to the 3.10 branch. |
bedevere-bot
removed
needs backport to 3.10
|
GH-28751 is a backport of this pull request to the 3.9 branch. |
…ythonGH-19588) * Support HTTP response status code 308 in urllib. HTTP response status code 308 is defined in https://tools.ietf.org/html/rfc7538 to be the permanent redirect variant of 307 (temporary redirect). * Update documentation to include http_error_308() * Add blurb for bpo-40321 fix Co-authored-by: Roland Crosby <[email protected]> (cherry picked from commit c379bc5) Co-authored-by: Jochem Schulenklopper <[email protected]>
…ythonGH-19588) * Support HTTP response status code 308 in urllib. HTTP response status code 308 is defined in https://tools.ietf.org/html/rfc7538 to be the permanent redirect variant of 307 (temporary redirect). * Update documentation to include http_error_308() * Add blurb for bpo-40321 fix Co-authored-by: Roland Crosby <[email protected]> (cherry picked from commit c379bc5) Co-authored-by: Jochem Schulenklopper <[email protected]>
Add support for HTTP response status code 308 (permanent redirect), the 307-variant of 301 as defined in IETF RFC 7538. The
httplibrary seems to support it, theurllib.requestlibrary missed it yet.https://bugs.python.org/issue40321