Skip to content

bpo-40493: fix function type comment parsing #19894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 4, 2020
Merged

bpo-40493: fix function type comment parsing #19894

merged 4 commits into from
May 4, 2020

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented May 4, 2020 •
edited by gvanrossum
Loading

The grammar for func_type_input rejected things like (*t1) ->t2. This fixes that.

https://bugs.python.org/issue40493

Automerge-Triggered-By: @gvanrossum

@hauntsaninja hauntsaninja requested a review from pablogsal as a code owner May 4, 2020 04:23
@hauntsaninja hauntsaninja mentioned this pull request May 4, 2020
Merged
gvanrossum
gvanrossum reviewed May 4, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! How did you find this out so quickly?

@hauntsaninja @gvanrossum
Update Grammar/python.gram
3df691b 
Co-authored-by: Guido van Rossum <[email protected]>
@hauntsaninja
Copy link
Contributor Author

I've been trying to fix various mypy test failures on 3.9!

gvanrossum
gvanrossum approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Looking forward to your fixes. (Please CC me on any mypy PRs you submit.)

gvanrossum
gvanrossum requested changes May 4, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, you need to regenerate parse.c (make regen-pegen).

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hauntsaninja
Copy link
Contributor Author

hauntsaninja commented May 4, 2020 •
edited
Loading

Right. Thanks for catching that! Github made it look deceptively easy there...

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@gvanrossum: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from gvanrossum May 4, 2020 04:48
@hauntsaninja
Copy link
Contributor Author

hauntsaninja commented May 4, 2020 •
edited
Loading

And happy to cc you on mypy changes! :-) So far it's only the one (already merged): python/mypy#8743 (although I independently made the subscript AST fix of yours)

gvanrossum
gvanrossum approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

@miss-islington
Copy link
Contributor

@hauntsaninja: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 603d354 into python:master May 4, 2020
@hauntsaninja hauntsaninja deleted the fixtype branch May 4, 2020 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hauntsaninja @bedevere-bot @miss-islington @gvanrossum @the-knights-who-say-ni