fastparse: add line and column information for extended slices #8743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Apr 30, 2020
mypy/fastparse.py
Outdated
| if isinstance(e.index, SliceExpr): | ||
| if ( | ||
| isinstance(e.index, SliceExpr) or | ||
| (sys.version_info <= (3, 9) and isinstance(e.index, TupleExpr)) |
There was a problem hiding this comment.
Does this mean that the version check is only true for versions earlier than 3.9.0 (since version_info has extra components beyond the first three) or up to 3.9.0? Please add a comment about this.
Or could you perhaps use < (3, 9) as the condition?
There was a problem hiding this comment.
Thanks! I did mean to use the latter. Changed a couple things and added comments; hopefully the result is more understandable.
Comparison using the ast3 nodes makes things a little clearer, as does commenting the code.
emmatyping
approved these changes
Apr 30, 2020
|
Thanks! |
|
Oh, thanks for this fix @hauntsaninja! I had been wondering about those diff lines in the CI logs for 3.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with Python 3.9 test failures