-
-
Notifications
You must be signed in to change notification settings - Fork 32k
bpo-45121: Fix issue when Protocol.__init__ raise RecursionError #28206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few questions, but the approach seems correct to me. Thanks.
Misc/NEWS.d/next/Core and Builtins/2021-09-07-17-10-16.bpo-45121.iG-Hsf.rst
Outdated
Show resolved
Hide resolved
…21.iG-Hsf.rst Co-authored-by: Ken Jin <[email protected]>
Misc/NEWS.d/next/Core and Builtins/2021-09-07-17-10-16.bpo-45121.iG-Hsf.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Yurii.
Thanks @uriyyo for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
…ubclass' __init__ (pythonGH-28206) (cherry picked from commit c11956a) Co-authored-by: Yurii Karabas <[email protected]>
Sorry, @uriyyo and @Fidget-Spinner, I could not cleanly backport this to |
GH-28232 is a backport of this pull request to the 3.10 branch. |
…ubclass' __init__ (pythonGH-28206)
GH-28233 is a backport of this pull request to the 3.9 branch. |
…om a subclass' __init__ (GH-28206) (GH-28233) Co-authored-by: Yurii Karabas <[email protected]>
…ubclass' __init__ (GH-28206) (GH-28232) (cherry picked from commit c11956a) Co-authored-by: Yurii Karabas <[email protected]>
…ubclass' __init__ (GH-28206) (GH-28232) (cherry picked from commit c11956a) Co-authored-by: Yurii Karabas <[email protected]>
https://bugs.python.org/issue45121