Skip to content

[3.10] bpo-45121: Fix RecursionError when calling Protocol.__init__ from a subclass' __init__ (GH-28206) #28232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 8, 2021

(cherry picked from commit c11956a)

Co-authored-by: Yurii Karabas [email protected]

https://bugs.python.org/issue45121

…ubclass' __init__ (pythonGH-28206)

(cherry picked from commit c11956a)

Co-authored-by: Yurii Karabas <[email protected]>
@miss-islington
Copy link
Contributor Author

@uriyyo and @Fidget-Spinner: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@uriyyo and @Fidget-Spinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@uriyyo and @Fidget-Spinner: Status check is done, and it's a success ✅ .

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Sep 8, 2021

@pablogsal I'm requesting to cherry pick this into 3.10.0 please.

As described by Shantanu in the bpo https://bugs.python.org/issue45121, a fix for a previous typing bug caused RecursionError, which would make his use case crash.

CC: @ambv too, thanks.

@ambv ambv merged commit c081649 into python:3.10 Sep 8, 2021
@miss-islington miss-islington deleted the backport-c11956a-3.10 branch September 8, 2021 15:05
pablogsal pushed a commit that referenced this pull request Sep 19, 2021
…ubclass' __init__ (GH-28206) (GH-28232)

(cherry picked from commit c11956a)

Co-authored-by: Yurii Karabas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants