-
-
Notifications
You must be signed in to change notification settings - Fork 32k
bpo-45436: Fix tkinter tests with Tcl/Tk 8.6.11+ #29077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since v8.6.11, a few configuration options seem to accept an empty value where they did not previously; particularly the `type` of a `Menu` widget, and the `compound` of an ttk widget with a label. Providing an explicit expected error message to `checkEnumParam` bypasses the check of an empty value, which no longer raises `TclError`.
In the interest of greening up a buildbot before another day of sprints starts further east of me, I'm going to go ahead and merge this. |
Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
GH-29080 is a backport of this pull request to the 3.10 branch. |
GH-29081 is a backport of this pull request to the 3.9 branch. |
Since v8.6.11, a few configuration options seem to accept an empty value where they did not previously; particularly the `type` of a `Menu` widget, and the `compound` of any ttk widget with a label. Providing an explicit expected error message to `checkEnumParam` bypasses the check of an empty value, which no longer raises `TclError`. (cherry picked from commit 4fe454c) Co-authored-by: Zachary Ware <[email protected]>
Since v8.6.11, a few configuration options seem to accept an empty value where they did not previously; particularly the `type` of a `Menu` widget, and the `compound` of any ttk widget with a label. Providing an explicit expected error message to `checkEnumParam` bypasses the check of an empty value, which no longer raises `TclError`. (cherry picked from commit 4fe454c) Co-authored-by: Zachary Ware <[email protected]>
Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
GH-29093 is a backport of this pull request to the 3.8 branch. |
Since v8.6.11, a few configuration options seem to accept an empty value where they did not previously; particularly the `type` of a `Menu` widget, and the `compound` of any ttk widget with a label. Providing an explicit expected error message to `checkEnumParam` bypasses the check of an empty value, which no longer raises `TclError`. (cherry picked from commit 4fe454c) Co-authored-by: Zachary Ware <[email protected]>
Since v8.6.11, a few configuration options seem to accept an empty value where they did not previously; particularly the `type` of a `Menu` widget, and the `compound` of any ttk widget with a label. Providing an explicit expected error message to `checkEnumParam` bypasses the check of an empty value, which no longer raises `TclError`. (cherry picked from commit 4fe454c) Co-authored-by: Zachary Ware <[email protected]>
|
Since v8.6.11, a few configuration options seem to accept an empty value where they did not previously; particularly the `type` of a `Menu` widget, and the `compound` of any ttk widget with a label. Providing an explicit expected error message to `checkEnumParam` bypasses the check of an empty value, which no longer raises `TclError`. (cherry picked from commit 4fe454c) Co-authored-by: Zachary Ware <[email protected]>
…thonGH-29093) Since v8.6.11, a few configuration options seem to accept an empty value where they did not previously; particularly the `type` of a `Menu` widget, and the `compound` of any ttk widget with a label. Providing an explicit expected error message to `checkEnumParam` bypasses the check of an empty value, which no longer raises `TclError`. (cherry picked from commit 4fe454c) Co-authored-by: Zachary Ware <[email protected]>
…thonGH-29093) Since v8.6.11, a few configuration options seem to accept an empty value where they did not previously; particularly the `type` of a `Menu` widget, and the `compound` of any ttk widget with a label. Providing an explicit expected error message to `checkEnumParam` bypasses the check of an empty value, which no longer raises `TclError`. (cherry picked from commit 4fe454c) Co-authored-by: Zachary Ware <[email protected]>
…thonGH-29093) Since v8.6.11, a few configuration options seem to accept an empty value where they did not previously; particularly the `type` of a `Menu` widget, and the `compound` of any ttk widget with a label. Providing an explicit expected error message to `checkEnumParam` bypasses the check of an empty value, which no longer raises `TclError`. (cherry picked from commit 4fe454c) Co-authored-by: Zachary Ware <[email protected]>
Since v8.6.11, a few configuration options seem to accept an empty value
where they did not previously; particularly the
type
of aMenu
widget, and the
compound
of an ttk widget with a label. Providing anexplicit expected error message to
checkEnumParam
bypasses the checkof an empty value, which no longer raises
TclError
.https://bugs.python.org/issue45436