[3.8] bpo-45436: Fix tkinter tests with Tcl/Tk 8.6.11+ (GH-29077) #29093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since v8.6.11, a few configuration options seem to accept an empty value where they did not previously; particularly the `type` of a `Menu` widget, and the `compound` of any ttk widget with a label. Providing an explicit expected error message to `checkEnumParam` bypasses the check of an empty value, which no longer raises `TclError`. (cherry picked from commit 4fe454c) Co-authored-by: Zachary Ware <[email protected]>
|
@zware: Status check is done, and it's a success ✅ . |
4 similar comments
|
@zware: Status check is done, and it's a success ✅ . |
|
@zware: Status check is done, and it's a success ✅ . |
|
@zware: Status check is done, and it's a success ✅ . |
|
@zware: Status check is done, and it's a success ✅ . |
bcail
pushed a commit
to bcail/cpython
that referenced
this pull request
Apr 6, 2024
…thonGH-29093) Since v8.6.11, a few configuration options seem to accept an empty value where they did not previously; particularly the `type` of a `Menu` widget, and the `compound` of any ttk widget with a label. Providing an explicit expected error message to `checkEnumParam` bypasses the check of an empty value, which no longer raises `TclError`. (cherry picked from commit 4fe454c) Co-authored-by: Zachary Ware <[email protected]>
bcail
pushed a commit
to bcail/cpython
that referenced
this pull request
Apr 9, 2024
…thonGH-29093) Since v8.6.11, a few configuration options seem to accept an empty value where they did not previously; particularly the `type` of a `Menu` widget, and the `compound` of any ttk widget with a label. Providing an explicit expected error message to `checkEnumParam` bypasses the check of an empty value, which no longer raises `TclError`. (cherry picked from commit 4fe454c) Co-authored-by: Zachary Ware <[email protected]>
bcail
pushed a commit
to bcail/cpython
that referenced
this pull request
Apr 9, 2024
…thonGH-29093) Since v8.6.11, a few configuration options seem to accept an empty value where they did not previously; particularly the `type` of a `Menu` widget, and the `compound` of any ttk widget with a label. Providing an explicit expected error message to `checkEnumParam` bypasses the check of an empty value, which no longer raises `TclError`. (cherry picked from commit 4fe454c) Co-authored-by: Zachary Ware <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v8.6.11, a few configuration options seem to accept an empty value
where they did not previously; particularly the
typeof aMenuwidget, and the
compoundof any ttk widget with a label. Providing anexplicit expected error message to
checkEnumParambypasses the checkof an empty value, which no longer raises
TclError.(cherry picked from commit 4fe454c)
Co-authored-by: Zachary Ware [email protected]
https://bugs.python.org/issue45436