Skip to content

bpo-12067: Add tests to test_compare #30667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

humbdrag
Copy link
Contributor

@humbdrag humbdrag commented Jan 18, 2022

@humbdrag
Copy link
Contributor Author

This is not visible to users so I think "skip news" is applicable to this.

@terryjreedy
Copy link
Member

The changelog has a section Tests, so I see no reason to not mention extensive changes like this.

This seems nearly identical to #60625 and #30651 so the first should have been left open to get the revised CLA tag. But we can go with this one.

@humbdrag
Copy link
Contributor Author

The changelog has a section Tests, so I see no reason to not mention extensive changes like this.

This seems nearly identical to #60625 and #30651 so the first should have been left open to get the revised CLA tag. But we can go with this one.

Thanks for the reply. Good point, added news file.

@humbdrag
Copy link
Contributor Author

@terryjreedy Sorry for tagging but any further thoughts?

@terryjreedy
Copy link
Member

This appears more or less identical to the original PR, #3199, with original attributions and merge conflicts removed. Our workflow is to credit original authors and, when possible, to fix merge conflicts on the PR. I did so fairly easily, leaving this as redundant. If you have any comments or suggestions, please make them there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants