Skip to content

PEP 752: Add more examples #3912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2024
Merged

PEP 752: Add more examples #3912

merged 1 commit into from
Aug 20, 2024

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Aug 19, 2024

Added:

  • Django
  • pytest
  • Sphinx
  • Apache Airflow

📚 Documentation preview 📚: https://pep-previews--3912.org.readthedocs.build/

@ofek ofek requested a review from warsaw as a code owner August 19, 2024 00:11
@warsaw warsaw merged commit 99e9a5f into python:main Aug 20, 2024
7 checks passed
@ofek ofek deleted the pep-752/examples branch August 20, 2024 01:29
Comment on lines +406 to +409
- `Django <https://www.djangoproject.com>`__ is one of the most widely used
frameworks in existence. They have the concept of `middleware`__ which
allows for third-party packages to modify the request/response cycle.
These packages are by convention prefixed by ``django-``.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ofek @warsaw Django apps are not limited to middlewares only, even though it's one of the ways to extend Django-based projects it seems odd to call it out here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! What did you think I should say here?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this (forgive the rST mangling)?

Suggested change
- `Django <https://www.djangoproject.com>`__ is one of the most widely used
frameworks in existence. They have the concept of `middleware`__ which
allows for third-party packages to modify the request/response cycle.
These packages are by convention prefixed by ``django-``.
- `Django <https://www.djangoproject.com>`__ is one of the most widely used
frameworks in existence and has a conecpt of "`reusable apps
<https://docs.djangoproject.com/en/5.1/intro/reusable-apps/>`__",
which are commonly installed via `third-party packages
<https://djangopackages.org/>`__ that implement a subset of functionality
to extend Django-based website projects. These packages are by convention
prefixed by ``django-`` or ``dj-``.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants